-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logfile endpoint cannot be disabled using the standard property #16298
Logfile endpoint cannot be disabled using the standard property #16298
Conversation
@yalov4uk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@yalov4uk Thank you for signing the Contributor License Agreement! |
@yalov4uk good catch, looks like the base condition was missed since day one! |
This comment has been minimized.
This comment has been minimized.
* pr/16298: Fix LogFile conditions to check for exposure as well
@yalov4uk thank you very much for your first contribution to Spring Boot. I've backported a fix to |
Actually the tests are not working anymore and I forgot to re-run them when looking at |
From the logs i cannot determine the problem. |
@yalov4uk you don't need to wait for CI to figure out the problem. Building the module or running that test from your IDE should have shown you the test failures. |
Currently in the project spring-boot-actuator-autoconfigure 2.1.3 there is no way to declaratively disable logfile endpoint if logging.file property exists.
So this PR is created to logfile actuator behave as other actuators.
And while i was fixing tests I had noticed that the test's method name was "logFileWebEndpointCanBeDisabled" whereas it tests bean creation.